Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about controlling browsing contexts. #487

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Add note about controlling browsing contexts. #487

merged 2 commits into from
Oct 30, 2020

Conversation

markafoltz
Copy link
Contributor

@markafoltz markafoltz commented Oct 18, 2020

This addresses Issue #338: Can the same browsing context act as a controller and receiver?

This adds a note just clarifying that the spec allows a receiving browsing context (created by starting one presentation) to start a second presentation, and thus become a controlling browsing context as well.

Not sure if this belongs in the main body of the specification, as this is a clarification and not a new requirement, but would be fine with putting it there as well.


Preview | Diff

@markafoltz markafoltz requested a review from tidoust October 18, 2020 17:40
@markafoltz markafoltz self-assigned this Oct 18, 2020
@markafoltz markafoltz linked an issue Oct 18, 2020 that may be closed by this pull request
@markafoltz
Copy link
Contributor Author

Addressing a long-standing issue, @louaybassbouss seemed to have some input back when it was opened. Feel free to take a look.

@tidoust
Copy link
Member

tidoust commented Oct 19, 2020

I suppose Web developers can detect that they may try to start a new presentation from an existing presentation simply by assessing whether window.PresentationRequest exists in the receiving browsing context. Would it be worth completing the note to say so, similar to the note in section 6.2.2?

@louaybassbouss
Copy link
Contributor

Thanks @mfoltzgoogle LGTM. Adding a note as @tidoust proposed make it more clear.

Copy link
Contributor

@louaybassbouss louaybassbouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markafoltz
Copy link
Contributor Author

Added a note along the lines of section 6.2.2. @tidoust, PTAL

@markafoltz
Copy link
Contributor Author

@tidoust, please add any comments if you think further changes are needed.

@markafoltz markafoltz deleted the fix-338 branch October 30, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can the same browsing context act as a controller and receiver?
3 participants