Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require a return for additional work for substantive changes #218

Closed
wants to merge 2 commits into from
Closed

Require a return for additional work for substantive changes #218

wants to merge 2 commits into from

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Oct 2, 2018 •
edited
Loading

Part of #28

frivoal added 2 commits October 2, 2018 18:28
@frivoal
Defines substantive and editorial changes for charters
e325bd5 
These were previously only defined for specs. Also, be consistent in the
use of editorial vs minor changes.

Part of w3c#28
@frivoal
Require a return for additional work for substantive changes
51cf832 
Part of w3c#28
@frivoal frivoal changed the title Frivoal 28 2 Require a return for additional work for substantive changes Oct 2, 2018
@frivoal frivoal mentioned this pull request Oct 2, 2018
Closed
@wseltzer wseltzer self-requested a review October 3, 2018 14:01
wseltzer
wseltzer suggested changes Oct 3, 2018
View reviewed changes
Copy link
Member

@wseltzer wseltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1

@frivoal
Copy link
Collaborator Author

frivoal commented Feb 4, 2019

This repository has been switched to using bikeshed. Pull Requests now need to be done against the master branch (instead of the gh-pages branch), against index.bs (instead of index.html).
This pull request predates that.

I could rebase it, but I intend to send a different pull request later to address this issue anyway, so closing instead.

@frivoal frivoal closed this Feb 4, 2019
@frivoal frivoal added the Closed: Retracted Closed by the person who opened the issue, no longer requesting anything be done. label Feb 4, 2019
@frivoal frivoal deleted the frivoal-28-2 branch February 4, 2019 09:23
@frivoal frivoal added this to the Process 2020 milestone Feb 19, 2019
@frivoal frivoal added the DoC This has been referenced from a Disposition of Comments (or predates the use of DoCs) label Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wseltzer wseltzer wseltzer requested changes

Assignees
No one assigned
Labels
Closed: Retracted Closed by the person who opened the issue, no longer requesting anything be done. DoC This has been referenced from a Disposition of Comments (or predates the use of DoCs)
Projects
None yet
Milestone
Process 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@frivoal @wseltzer