editorial: Define a task source for the tasks run by this specification. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchris
approved these changes
Feb 8, 2021
This allows implementations to better decide when to run events and tasks from this spec in relation to others, and specifying a task source is a requirement when queuing tasks like we do [1]. [1] https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-for-spec-authors Rather than picking a generic task source from the HTML spec, we define a new task source, the "screen wake lock task source", following the current guidance in w3ctag/design-principles#38 (which is still open).
rakuco
force-pushed
the
editorial/define-task-source
branch
from
83d8dc8 to
fa8693f
Compare
reillyeon
approved these changes
Feb 9, 2021
6 tasks
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Adapt to w3c/screen-wake-lock#301, which defined a task source for the Screen Wake Lock spec. The new task type is also allowed in workers because of our system wake lock implementation: even though we always deny system wake lock requests, the code is in place is tested by browser and web tests. Bug: 1176157 Change-Id: Ide78131629048d68f98efd35ea95892f18b83b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2682351 Reviewed-by: Reilly Grant <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Commit-Queue: Raphael Kubo da Costa <[email protected]> Cr-Commit-Position: refs/heads/master@{#852536} GitOrigin-RevId: 5d00f1fb076a71d27719cd00f2bf1066e4909fc7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows implementations to better decide when to run events and tasks
from this spec in relation to others, and specifying a task source is a
requirement when queuing tasks like we do [1].
[1] https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-for-spec-authors
Rather than picking a generic task source from the HTML spec, we define a
new task source, the "screen wake lock task source", following the current
guidance in w3ctag/design-principles#38 (which is still open).
Implementation commitment:
Preview | Diff