-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup priv-sec wording + recommend an indicator #323
Conversation
index.html
Outdated
</h2> | ||
<p> | ||
The `"screen-wake-lock"` <a>powerful feature</a> defines a | ||
<a>permission revocation algorithm</a>. To invoke the <dfn>Screen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started referencing the "permission revocation algorithm" in #297 to make sure this was properly integrated with the Permissions API spec. The new "revoke the screen-wake-lock permission" definition above is not referenced anywhere and it's not clear how it would integrate with the Permissions API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Permissions API provides a permission revocation algorithm hook for specifications to take action when a permission is revoked. The definition above should be declared as the permission revocation algorithm for the "screen-wake-lock"
permission.
index.html
Outdated
</h2> | ||
<p> | ||
The `"screen-wake-lock"` <a>powerful feature</a> defines a | ||
<a>permission revocation algorithm</a>. To invoke the <dfn>Screen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Permissions API provides a permission revocation algorithm hook for specifications to take action when a permission is revoked. The definition above should be declared as the permission revocation algorithm for the "screen-wake-lock"
permission.
Co-authored-by: Reilly Grant <[email protected]>
e7d65c4
to
c4c634e
Compare
sorry for my screwup on this PR! Now only deals with #282. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. It'd be good for either @David-Chadwick or @reillyeon to take another look as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM with the caveat that Chromium currently chooses not to implement an explicit notification that a site is holding a screen wake lock as our Security UX team believes that it is sufficiently obvious from the fact that the device's screen remains on.
I think that's fine. I'm sure if it becomes an issue, users will get notified one way or another. |
…level. Follow-up to commit 0080849 ('Cleanup priv-sec wording + recommend an indicator (w3c#323)'). @David-Chadwick suggested adding this part of the original text back because it is still relevant (see w3c#323).
…level. (#328) Follow-up to commit 0080849 ('Cleanup priv-sec wording + recommend an indicator (#323)'). @David-Chadwick suggested adding this part of the original text back because it is still relevant (see #323).
Closes #282
Preview | Diff