Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Recommended Mark Names section. #106

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Add Recommended Mark Names section. #106

merged 11 commits into from
Nov 6, 2023

Conversation

anniesullie
Copy link
Collaborator

@anniesullie anniesullie commented Oct 19, 2023 •
edited by pr-preview bot
Loading

This addresses #103.

Preview | Diff

@anniesullie anniesullie requested a review from yoavweiss October 19, 2023 14:59
@anniesullie
Copy link
Collaborator Author

Note: this pulls from the L1 spec: https://www.w3.org/TR/user-timing-1/#:~:text=interface%20%5BNavigation%20Timing%5D.-,recommended%20mark%20names,-Developers%20are%20encouraged

clelland
clelland reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, in a drive-by review :)

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
yoavweiss
yoavweiss reviewed Oct 20, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
npm1
npm1 requested changes Oct 23, 2023
View reviewed changes
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
yoavweiss
yoavweiss reviewed Oct 25, 2023
View reviewed changes
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
marcoscaceres
marcoscaceres reviewed Oct 30, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
npm1
npm1 reviewed Nov 1, 2023
View reviewed changes
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
yoavweiss
yoavweiss reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A couple of nits

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
yoavweiss
yoavweiss approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss
Copy link
Contributor

@mmocny suggested offline that it might be interesting to think through how should developers report these timings. That can be as a followup.

@npm1 npm1 self-requested a review November 6, 2023 16:42
npm1
npm1 reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be reviewed by someone outside of Chrome, otherwise this PR is not useful.

@anniesullie anniesullie assigned nicjansma and unassigned nicjansma Nov 6, 2023
@anniesullie anniesullie requested a review from nicjansma November 6, 2023 17:21
@anniesullie
Copy link
Collaborator Author

Should probably be reviewed by someone outside of Chrome, otherwise this PR is not useful.

@nicjansma do you have time to review?

@nicjansma
Copy link

LGTM as well!

npm1
npm1 approved these changes Nov 6, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
@anniesullie anniesullie merged commit d59be49 into gh-pages Nov 6, 2023
1 check passed
@anniesullie anniesullie deleted the anniesullie-issue-103 branch November 6, 2023 19:50
@anniesullie anniesullie mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres left review comments

@jyasskin jyasskin jyasskin left review comments

@clelland clelland clelland left review comments

@npm1 npm1 npm1 approved these changes

@nicjansma nicjansma nicjansma approved these changes

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anniesullie @yoavweiss @nicjansma @clelland @jyasskin @marcoscaceres @npm1