Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register entry types #45

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Register entry types #45

merged 1 commit into from
Nov 30, 2018

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Nov 30, 2018 •
edited by pr-preview bot
Loading

This change adds the calls to register entryTypes "mark" and "measure".

Preview | Diff

@npm1
Register entry types
ef536c5 
This change adds the calls to register entryTypes "mark" and "measure".
@npm1
Copy link
Contributor Author

npm1 commented Nov 30, 2018

@spanicker @yoavweiss PTAL!

yoavweiss
yoavweiss approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss yoavweiss merged commit c726dad into w3c:gh-pages Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npm1 @yoavweiss