Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RangeErrors with TypeErrors #58

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Replace RangeErrors with TypeErrors #58

merged 1 commit into from
Apr 25, 2019

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Apr 25, 2019 •
edited by pr-preview bot
Loading

Per feedback from @bzbarsky, it seems TypeErrors should be used even for negative checks.

Preview | Diff

@npm1 npm1 requested a review from yoavweiss April 25, 2019 15:42
yoavweiss
yoavweiss approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npm1 npm1 merged commit d2bbcd3 into gh-pages Apr 25, 2019
@npm1 npm1 deleted the range-errors branch April 25, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npm1 @yoavweiss