Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deserialize the serialized detail #61

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Deserialize the serialized detail #61

merged 1 commit into from
Jun 25, 2019

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Jun 25, 2019 •
edited by pr-preview bot
Loading

Fixes #59

Preview | Diff

@npm1 npm1 requested a review from yoavweiss June 25, 2019 18:22
@npm1 npm1 changed the title Deserialize the seralized detail Deserialize the serialized detail Jun 25, 2019
yoavweiss
yoavweiss approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss yoavweiss merged commit 495ba7b into gh-pages Jun 25, 2019
@yoavweiss yoavweiss deleted the deserialize branch February 3, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StructuredDeserialize should be used; serialization records cannot be returned from IDL getters
2 participants
@npm1 @yoavweiss