Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change editors #78

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Change editors #78

merged 1 commit into from
Mar 8, 2021

Conversation

yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented Mar 8, 2021 •
edited by pr-preview bot
Loading

Moving @igrigorik to former editors..

Preview | Diff

@yoavweiss yoavweiss requested review from igrigorik and npm1 March 8, 2021 14:49
npm1
npm1 reviewed Mar 8, 2021
View reviewed changes
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing all the lines? Can we restrict the change to the title of this PR?

@yoavweiss
Copy link
Contributor Author

Why are we changing all the lines? Can we restrict the change to the title of this PR?

Oh my... Accidental :/

@yoavweiss
Copy link
Contributor Author

Why are we changing all the lines? Can we restrict the change to the title of this PR?

Fixed!

npm1
npm1 approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yoavweiss yoavweiss merged commit 0268b1c into w3c:gh-pages Mar 8, 2021
@yoavweiss yoavweiss deleted the change_editors branch March 8, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npm1 npm1 npm1 approved these changes

@igrigorik igrigorik Awaiting requested review from igrigorik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoavweiss @npm1