Algorithm tests & interop #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
aljones15
approved these changes
Oct 18, 2024
tests/helpers.js
Outdated
| @@ -145,3 +174,17 @@ export async function decodeSl({encodedList}) { | |||
| 'representation of a GZIP-compressed bitstring.'); | |||
| return decoded; | |||
| } | |||
|
|
|||
| export async function addJsonAttachment(fileName, content) { | |||
There was a problem hiding this comment.
I have no objections to adding json output to allure, but disabling console.log does cause concern. why is console.log disabled here?
There was a problem hiding this comment.
I'm aware it does, the reason is that if the test suite is ran with the db reporter, allure will complain that there is no allure framework loaded. It prints one line every time with this warning.
Disabling the console for this function call only was the most convenient method I found to avoid this.
This has been removed from this PR entirely we can discuss it in a subsequent PR.
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
…list-test-suite into algorithm-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pending on merging #46
Adds all remaining normative statements and interop tests.