-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting up the echidna action #161
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msporny would be good if you checked it; a second pair of eyes is always helpful...
I presume the PR must be merged first before it can be used. The error check error seems to be a bootstrapping problem. @msporny wdyt? |
The error was because the server-based ReSpec build process failed. It's probably just a transient error; if the use cases document builds locally, it's probably fine. |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
We're going to accept this and see if it works once the commit is pushed. |
Ok. We were able to get rid of the node.js error by updating the checkout task to v4. However, now the failures are SVG complaints about rects without width & height. This appears to be because of empty rects Can we get respec-mermaid bumped to the latest version? I believe @msporny took care of this last time. Although, to be fair, we have not verified that the latest mermaid has a fix for this. I'm reviewing their issue log to see if there's anything. |
Digging into this further, we can definitively say that the mermaid is generating an improper We've escalated this in an existing issue at mermaid-js/mermaid#1766 (comment) but that issue is 4+ years old and we may not be able to get traction. The other alternative is to turn off strict checking for SVGs, but we want to first try to get the mermaid fixed. |
It should be possible to add a simple script that converts The only point is that I am not sure how mermaid is exactly used within a respec file, ie, at which stage. I seem to remember that somebody from DB has done that (@msporny should know), so adding that script at the right place should be possible... |
Yeah, we can fix this in respec-mermaid, someone just needs to raise the PR. It's not a difficult "fix", just need to find someone that has the bandwidth to do it. |
I can verify that the previous configuration did not fail. The output HTML does have a |
The repository secret has also been generated and added to the repo