Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up the echidna action #161

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Setting up the echidna action #161

wants to merge 3 commits into from

Conversation

iherman
Copy link
Member

@iherman iherman commented Sep 29, 2024

The repository secret has also been generated and added to the repo

@iherman iherman requested a review from KDean-GS1 as a code owner September 29, 2024 13:10
@iherman iherman requested a review from msporny September 29, 2024 13:10
Copy link
Member Author

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msporny would be good if you checked it; a second pair of eyes is always helpful...

@iherman
Copy link
Member Author

iherman commented Sep 30, 2024

I presume the PR must be merged first before it can be used. The error check error seems to be a bootstrapping problem. @msporny wdyt?

@msporny
Copy link
Member

msporny commented Sep 30, 2024

I presume the PR must be merged first before it can be used. The error check error seems to be a bootstrapping problem. @msporny wdyt?

The error was because the server-based ReSpec build process failed. It's probably just a transient error; if the use cases document builds locally, it's probably fine.

@jandrieu
Copy link
Collaborator

jandrieu commented Jan 7, 2025

We're going to accept this and see if it works once the commit is pushed.

@jandrieu
Copy link
Collaborator

jandrieu commented Jan 7, 2025

Ok. We were able to get rid of the node.js error by updating the checkout task to v4.

However, now the failures are SVG complaints about rects without width & height.

This appears to be because of empty rects <rect></rect> and improper
inside a being generated by mermaid.

Can we get respec-mermaid bumped to the latest version? I believe @msporny took care of this last time.
w3c/respec-mermaid@1d8ea48#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R20 through
w3c/respec-mermaid@546baa9

Although, to be fair, we have not verified that the latest mermaid has a fix for this. I'm reviewing their issue log to see if there's anything.

@jandrieu
Copy link
Collaborator

Digging into this further, we can definitively say that the mermaid is generating an improper <br> tag where it should be a <br/> tag.

We've escalated this in an existing issue at mermaid-js/mermaid#1766 (comment) but that issue is 4+ years old and we may not be able to get traction.

The other alternative is to turn off strict checking for SVGs, but we want to first try to get the mermaid fixed.

@iherman
Copy link
Member Author

iherman commented Jan 23, 2025

It should be possible to add a simple script that converts <br> tags to <br/>. It is possible to add script references to respec to be run before or after it goes through its processing.

The only point is that I am not sure how mermaid is exactly used within a respec file, ie, at which stage. I seem to remember that somebody from DB has done that (@msporny should know), so adding that script at the right place should be possible...

@msporny
Copy link
Member

msporny commented Jan 23, 2025

Yeah, we can fix this in respec-mermaid, someone just needs to raise the PR. It's not a difficult "fix", just need to find someone that has the bandwidth to do it.

@jandrieu
Copy link
Collaborator

jandrieu commented Jan 23, 2025

I can verify that the previous configuration did not fail.

The output HTML does have a <br> in the middle of a span, but there's not complaint about it in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants