Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For publication / deploy - Landmarks Pattern and Dialog Example Updates #227

Merged
merged 15 commits into from
Jun 20, 2023
Merged

For publication / deploy - Landmarks Pattern and Dialog Example Updates #227

merged 15 commits into from
Jun 20, 2023

Conversation

alflennik
Copy link
Contributor

@alflennik alflennik commented Jun 13, 2023 •
edited by mcking65
Loading

Hi @shawna-slh, we would like to deploy a new version of the APG which includes a new landmarks pattern and updates to the dialog example. It's already part of the way into Tuesday, which is the day we do deploys, so apologies for requesting a bit late. If there is a chance we could deploy this week, that would be fantastic.

List of changes since April 13 deploy follows.

Grid Pattern: Fix typos (capitalization) (pull #2701)

By icecream17 on 2023-06-05

  • capitalization consistency: [-c][+C]ontrol + End
  • lowercase Up ("one cell [-U][+u]p" x3)

View commit c0054c2d

Read Me First: Remove reference to Internet Explorer in browser support section (pull #2683)

By jugglinmike on 2023-06-06

Per consensus of the 2023-04-25 meeting of the ARIA Authoring
Practices Task Force (https://www.w3.org/2023/04/25-aria-apg-minutes.html), remove mention of Internet Explorer from the browser support section.

View commit ca63ddf0

Datepicker Modal Dialog: Fixed next/prev month bug and improve adherence with APG code style guide (pull #2643)

By Jon Gunderson on 2023-06-06

This PR complements PR #2618 to provide the remaining changes to resolve issue #2581.

This PR changes behavior of commands for next and previous month and year In the date picker dialog when the currently focused date does not exist in the previous or next month or year. With these changes, if the same day number does not exist in the newly displayed month, the last day of the newly displayed month receives focus.

In addition to the above enhancement, this PR also includes the following changes:

  • Updates coding practices to use class constructor and pointer events
  • Updates documentation of page up and page down commands
  • Updates regression tests for page up and page down commands

Co-authored-by: Matt King [email protected]

View commit 32c7ef25

Add landmark pattern page (pull #2670)

By Matt King on 2023-06-08

Resolves issue #2645 by adding a new page that describes landmarks as a pattern.
The pattern page references the landmarks practice for information about each of the landmark types.
Now, readers will find landmark information on both the practices and patterns pages.

View commit fec70323

Hiding Semantics Practice Page: Add missing word "that" (pull #2704)

By Paul BROWN on 2023-06-10

Editorial correction to add a missing word and missing comma.

Co-authored-by: Matt King [email protected]

View commit 08fee221

Layout Grid Example 3: Remove link to archived ARIA FAQ page (pull #2721)

By Daniel Montalvo on 2023-06-10

View commit b61ac05c

Landmark examples: Update links to related documents and SkipTo script (pull #2624)

By Jon Gunderson on 2023-06-10

Minor editorial and code maintenance changes to all landmark example pages:

  • updated SkipTo script to version 5.2
  • Modify Skipto script tag to use new configuration data parameter
  • updated URL targets in links to two related resources
  • Update copyright date

Co-authored-by: Matt King [email protected]

View commit 4adb78ea

alflennik and others added 14 commits May 3, 2023 14:17
@netlify
Copy link

netlify bot commented Jun 13, 2023 •
edited
Loading

✅ Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit d505403
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/648fffbc3b547d0008bd8a0f
😎 Deploy Preview https://deploy-preview-227--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@alflennik alflennik changed the title WIP For publication / deploy - Landmarks Pattern and Dialog Example Updates Jun 13, 2023
@alflennik
Copy link
Contributor Author

Failing checks are due to Netlify's struggle with Git Submodules - I verified that the preview site is working properly and we should be good to go.

@shawna-slh
Copy link
Contributor

Hi @alflennik

Friendly reminder that Updating WAI Website Resources says:

  • If other than a simple content update, coordinate with Shawn at least the week before.
  • If a simple content update, then by Monday midnight US Eastern time.

And:

  • Include a brief summary of the changes. Explain everything that the website manager and/or technical lead needs to particularly be aware of.
  • Include a link to the Task Force and/or Working Group approval to publish.

Given the history of issues, I think we need to consider this more than a simple update, especially since this PR is failing checks. Why are some PRs passing check and some not? I would be much more comfortable if the PR passed checks.

Given history of issues, unless the checks are all passing and indeed it is just simple content edits, then let’s schedule time for me to publish when you are available in case there are problems.

@alflennik
Copy link
Contributor Author

Hi @shawna-slh, here is a link to the aria-practices approval of release: https://github.com/w3c/aria-practices/wiki/June-6%2C-2023-Agenda

Note @mcking65 that Shawn said she will release the changes next Tuesday.

@mcking65
Copy link
Contributor

@shawna-slh @alflennik

I added a list of changes since the April 13 deploy to the top comment.

Reviewing the commits from the builds seems like a fruitless exercise because they are all named with some generic string. The build process doesn't pull any useful information from the aria-practices logs.

@mcking65
Copy link
Contributor

mcking65 commented Jun 14, 2023 •
edited
Loading

@alflennik @shawna-slh

We might have a couple more PRs merged into aria-practices:main by Monday. Would we be able to add them to the deploy?

One is an update to the skipto script and the other is a simple editorial correction:

@shawna-slh
Copy link
Contributor

Shawn said she will release the changes next Tuesday.

Sorry, not quite. I said:

... Why are some PRs passing check and some not? I would be much more comfortable if the PR passed checks.

Please would you look into this more.

And:

Given history of issues, unless the checks are all passing and indeed it is just simple content edits, then let’s schedule time for me to publish when you are available in case there are problems.

We'd need to schedule a specific time.

Would we be able to add them to the deploy?

Sure, as long as they are sufficiently tested and approved. And ideally all checks pass and the preview works. :-)

@howard-e
Copy link
Contributor

howard-e commented Jun 15, 2023 •
edited
Loading

... especially since this PR is failing checks. ...

Hi @shawna-slh. I'm thinking some bad caching + de-sync with Netlify may have happened here. When Netlify was doing the preparing the repo step, the error that was initially shown is:

fatal: remote error: upload-pack: not our ref cf01cbd9eed167a0ffe96ec2371c1d915271f535

The commit ref doesn’t seem to exist in either aria-practices or wai-aria-practices so we're unsure what it's trying to reference here (it may have been some removed commit, or coming from a private repo, etc) so we figured this may have been some caching hiccup.

We’ve rebuilt the aria-practices.netlify.app by doing a clear cache and retry with latest commit for this PR (and would suggest the same be done for the wai-aria-practices2.netlify.app build). And it now displays the build as passing in our Netlify logs and that is also reflected in the auto-generated Netlify comment in this PR but the same isn’t reflected in the build status of this PR. So some de-sync may have happened here in Netlify reflecting the updated state of main, when used as the head ref in a PR.

Why are some PRs passing check and some not? I would be much more comfortable if the PR passed checks.

For PRs #228, #230 and #231, the same not our ref error is reflected in the logs for wai-aria-practices2.netlify.app but not aria-practices.netlify.app, as that builds successfully for the noted PRs and is reflected in the PRs' statuses and also in the generated Netlify comments.

I'd think that doing a clear cache and retry with the latest commit on those PRs and this for wai-aria-practices2.netlify.app, and verifying that it builds successfully should address that.

Would we be able to add them to the deploy?

For a proper green check, it may be good to also re-do this publication PR if the other intended updates are ready by then.

@shawna-slh
Copy link
Contributor

clear cache and retry with the latest commit

Done on wai-aria-practices2
Maybe this means it's OK? https://app.netlify.com/sites/wai-aria-practices2/deploys/648ba0628fa469046df3b45e

For a proper green check, it may be good to also re-do this publication PR...

+1

Thanks.

@shawna-slh
Copy link
Contributor

We'd need to schedule a specific time.

@alflennik @howard-e

Does Tuesday 20 June at 10:30 CT work for you?

@ccanash
Copy link
Contributor

ccanash commented Jun 16, 2023

Hi @shawna-slh , would it be possible to schedule this for a little later, 12:30 CT? The team is already offline for the weekend and we have Juneteenth off so we they will be back on online Tuesday morning. Thank you

@shawna-slh
Copy link
Contributor

shawna-slh commented Jun 20, 2023 •
edited
Loading

I am setting up a few things, and will get to this soon. ~10 minutes...

@shawna-slh shawna-slh merged commit 013d619 into publication Jun 20, 2023
@shawna-slh
Copy link
Contributor

deploy seems to have worked fine! Please check live site and let me know if all good...

@shawna-slh
Copy link
Contributor

/me checks w3c/aria-practices@ca63ddf is indeed live at https://www.w3.org/WAI/ARIA/apg/practices/read-me-first/

@mcking65
Copy link
Contributor

I have verified all the fixes in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shawna-slh shawna-slh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alflennik @shawna-slh @mcking65 @howard-e @ccanash @michael-n-cooper-bot