Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stopgap fix for feed display star images #245

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Remove stopgap fix for feed display star images #245

merged 1 commit into from
Aug 1, 2023

Conversation

howard-e
Copy link
Contributor

Resolves #225.

@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited
Loading

✅ Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit 2ce796c
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/64c7defe3251380008bf1360
😎 Deploy Preview https://deploy-preview-245--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@howard-e howard-e mentioned this pull request Jul 31, 2023
Closed
alflennik
alflennik approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebuilt the site and verified that it still works with this removed. It works. Side note, I think the new stars look slightly nicer than the old ones. Good old vector graphics.

@howard-e howard-e merged commit 50e4ac7 into main Aug 1, 2023
@howard-e howard-e deleted the remove-feeddisplay-temp-fix branch August 1, 2023 17:12
@mcking65
Copy link
Contributor

mcking65 commented Aug 1, 2023

Thank you @howard-e and @alflennik

@howard-e howard-e mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alflennik alflennik alflennik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove feedDisplay images transform
3 participants
@howard-e @mcking65 @alflennik