generated from w3c/wai-resource-template
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Search for patterns, toggle grid/list view #329
Merged
+495
−105
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
55509f6
Update with APG feature branch content
stalgiag 11272ba
Initial style updates
stalgiag 41b6a46
layout for search form
stalgiag 84eae26
Final pass on styles, built MD file
stalgiag bd65772
Remove unused icon assetts
stalgiag 70c2b43
Update build repo after moving view toggle js code
stalgiag 76c72ac
Styles for accessible h2 for Filter form
stalgiag 9598221
No results found element and styles
stalgiag 3e794ee
Fix styling for practices tiles
stalgiag e736435
Updates for clear button and removal of submit in filter patterns
stalgiag 53e2eae
Update aria-practices gitmodule latest commit
howard-e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Initial style updates
commit 11272ba436d8397a076cacdc3f5cce8f1bee74ed
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the Practices page uses the
tile
classname so this change (and other related css rules) would also affect thereThis change:
![Screenshot 2024-06-24 at 3 18 11 PM](https://private-user-images.githubusercontent.com/7191577/342465525-4d85b896-baea-4627-84c1-53cee96d3c6a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzQ4NzMsIm5iZiI6MTczOTY3NDU3MywicGF0aCI6Ii83MTkxNTc3LzM0MjQ2NTUyNS00ZDg1Yjg5Ni1iYWVhLTQ2MjctODRjMS01M2NlZTk2ZDNjNmEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMDI1NjEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWMzYzk0MGYyZmE5ZDQ3MzM5ZmFkYTExYjg0NmYzZDI4YjA5ZjRkOTA1NjNkMDE4OWNkNTQ1Y2FmYjlhMDk0MyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.MENPyN1MKFy1PTM9Z8wI8h2_EZTpvDbqKry6fSFPh2E)
vs what's on production:
![Screenshot 2024-06-24 at 3 17 54 PM](https://private-user-images.githubusercontent.com/7191577/342465704-7f6f252c-8801-4bc6-98c3-96b8fd36eb57.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzQ4NzMsIm5iZiI6MTczOTY3NDU3MywicGF0aCI6Ii83MTkxNTc3LzM0MjQ2NTcwNC03ZjZmMjUyYy04ODAxLTRiYzYtOThjMy05NmI4ZmQzNmViNTcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMDI1NjEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjRjZDlmMjJlNzM1ZGUwZjhmMWRmZTUzMTIxZmQyOGVlZGNlNDMyZWYwY2M4YzcyYjg4NDUyYjBlMGUwZTYyOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.K_NFuwGwj2HuIQXeIiz0i7JUCsHSLXPAz1VDHwb3vGM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow clutch catch thank you! I obviously didn't realize that it was being used elsewhere. Have been in module land for too long.
My original intent for renaming was just to get away from potentially misleading classes (ie avoid a situation in which a
ul class="list"
hasli class="tile"
). I handled the regression with this commit (3e794ee) but if we wanted to take it a step further I would advocate for getting rid of both the "tile" and "pattern" classes in favor of some more generic name for both so that all styling can just be derived from the class of the parentul
across both pages. This isn't essential though.