-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/Added page title to reflect ACT rule order and added lang where missing #317
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wai-wcag-act-rules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@carlosapaduarte @Jym77, I'm not able to ask for reviewers or add a label. |
Neither can we. That is because this is the wcag-act-rules and not the act-rules.github.io where we usually work. Are you sure you want to PR into this repo @giacomo-petri ? |
@carlosapaduarte, |
@giacomo-petri I might be wrong but I'm under the impression that these files get built automatically from the sources in the act-rules.github.io repo. @WilcoFiers should know what is the best way to address this. |
Thanks @carlosapaduarte for replying to this. @giacomo-petri -- this is indeed my understanding too. We should not modify these files in this repo, as they get automatically committed to it via scripts in the ACT Tools suite. |
Thanks for the prompt feedback @carlosapaduarte @daniel-montalvo. Are we certain about this? In the repository https://github.com/act-rules/act-rules.github.io, most examples lack both the lang attribute and a title tag. However, when accessing the test cases through a browser, some do have a title and language attribute, while others do not. Additionally, the JSON file available here: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases.json appears correct but doesn't fully align with the actual test cases. For instance, in the first test case mentioned in this PR description (efcd5df49b39506dac34a310f4b8bc0df71716d3), the testcaseTitle in the JSON is "Passed Example 9," which matches the example name in the rule (https://www.w3.org/WAI/standards-guidelines/act/rules/73f2c2#passed-example-9). However, when opening the test case directly (https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/73f2c2/efcd5df49b39506dac34a310f4b8bc0df71716d3.html), the title is shown as "Passed Example 8." If updates need to be made in a different directory, please let me know, and I’ll address it accordingly. I firmly believe that now that the ACT rules (and consequently their test cases) are linked from the WCAG Understanding Documents, they should be accessible, except, of course, for failing examples, which are intentionally designed to fail. |
Closes: #269
This PR addresses only approved rules.
Issues solved:
testcase a746b387d13dc61266d1fcde19b91b89441b1be7.html the page title of Passing Example 1 is missing. Updated page title to reflect the ACT order.
testcase 1583a11fb07127fb3315fa19f3baaf876aa42aa4.html the page title of Passing Example 2 is missing. Updated page title to reflect the ACT order.
testcase 034e1e1a46cfa6d3fe3bcc69ac45ffb6c5d55148.html the page title of Passing Example 3 is missing. Updated page title to reflect the ACT order.
testcase d8c5a59532ae0624edd875aea31ef39086873b7a.html the page title of Passing Example 4 is missing. Updated page title to reflect the ACT order.
testcase cecfce83c949d20c816a0e43cbc4c26a3468754b.html the page title of Passing Example 5 is missing. Updated page title to reflect the ACT order.
testcase b1765660b28464b5a73e502ef30b7370ba294ff5.html the page title of Failed Example 1 is missing. Updated page title to reflect the ACT order.
testcase 49b66676ed867c75368e31c1e06b28255df8089e.html the page title of Failed Example 2 is missing. Updated page title to reflect the ACT order.
testcase 78de8b1ca470302aebb53065c32eddf08da008b5.html the page title of Failed Example 3 is missing. Updated page title to reflect the ACT order.
testcase 795698c08fc5d404b649d0c367bedc3e83462d43.html the page title of Failed Example 4 is missing. Updated page title to reflect the ACT order.
testcase d8ba52b5fa5e123def1f778821219aaec20ca0fe.html the page title of Failed Example 5 is missing. Updated page title to reflect the ACT order.
testcase 61f81c57325a77a89481f036e4e2116399fb6714.html the page title of Failed Example 6 is missing. Updated page title to reflect the ACT order.
testcase 5ba0306adadd581e4331b9415c2ef9f8ecccc0f2.html the page title of Failed Example 7 is missing. Updated page title to reflect the ACT order.
testcase 915cdae554a817caa4792101fde1adf14563227d.html the page title of Failed Example 8 is missing. Updated page title to reflect the ACT order.
testcase 50e733e0c505a556fc53e6265eb5b432823570f7.html the page title of Failed Example 9 is missing. Updated page title to reflect the ACT order.
testcase b5ca868de7980f6944142ecdb849f47ad2cdfb5c.html the page title of Passed Example 3 is missing. Updated the page title to reflect the ACT order.