Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Working Example ARIA24 #1016

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update Working Example ARIA24 #1016

wants to merge 3 commits into from

Conversation

JAWS-test2
Copy link
Contributor

@JAWS-test2 JAWS-test2 commented Jan 26, 2020 •
edited
Loading

Fixes: #1007

I have changed the following:

  • frame (shadow) around the stars, so that contrast is sufficient
  • contrast between yellow and gray in the star increased, thus contrast greater than 3:1
  • all font icons marked with aria-hidden=true, and aria-label removed
  • alternative text of the icons in the source code as text (class=sr-only), so that the text is also visible without CSS (see F87)

If these changes are accepted, I would also change the ARIA24 file to update the source code examples

@innoticFR innoticFR mentioned this pull request Oct 25, 2020
Open
Base automatically changed from master to main March 5, 2021 20:42
@stevefaulkner stevefaulkner self-requested a review October 18, 2024 15:56
@netlify Netlify
Copy link

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit e643e2f
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/67814f2df77a090008bc1a10
😎 Deploy Preview https://deploy-preview-1016--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ljoakley ljoakley self-assigned this Jan 10, 2025
@ljoakley ljoakley removed their assignment Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevefaulkner stevefaulkner Awaiting requested review from stevefaulkner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F87 and custom-styled form controls
3 participants
@JAWS-test2 @ljoakley @patrickhlauke