Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import understanding SC 1.4.13's images into repo #446

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

EricDunsworth
Copy link
Contributor

WCAG 2.1's Understanding Content on Hover or Focus page contains several example images. Previously, they were being hotlinked from Imgur. However, all of the other understanding pages' images are situated within the repo itself. This commit moves the aforementioned page's images into the repo and modifies their file names to be more readable.

+@neilmispelaar
Thanks for providing me with copies of the images.

WCAG 2.1's Understanding Content on Hover or Focus page contains several example images. Previously, they were being hotlinked from Imgur. However, all of the other understanding pages' images are situated within the repo itself. This commit moves the aforementioned page's images into the repo and modifies their file names to be more readable.

+@neilmispelaar
Thanks for providing me with copies of the images.
@EricDunsworth
Copy link
Contributor Author

Btw Travis-CI's build failure doesn't seem to be related to this PR's changes.

@alastc
Copy link
Contributor

alastc commented Aug 21, 2018

@michael-n-cooper I can't see anything wrong with the PR that would fail the build process, perhaps it is just because it is from an external fork? The preview is fine, what's the easiest way to 'import' the change?

@alastc alastc merged commit 97041d9 into w3c:master Sep 13, 2018
@alastc
Copy link
Contributor

alastc commented Sep 13, 2018

Thanks for that, we've checked, it was a travis issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants