-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the spec to use HTML's navigables instead of browsing contexts #729
Conversation
d492c61
to
e09af2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good, thanks! Just a few cases where we're linking to the wrong thing or inventing a concept that doesn't seem to exist.
@jgraham PTAL again |
The Browser Testing and Tools Working Group just discussed
The full IRC log of that discussion<AutomatedTester> topic: Navigable rewrite<AutomatedTester> github: https://github.com//pull/729 <jgraham> q+ <AutomatedTester> orkon: the last time we were updating to use navigables instead of contexts <AutomatedTester> ... it would be good if folks can review it <AutomatedTester> ack next <AutomatedTester> jgraham: I looked earlier and it mostly looks right. I will try read it again very soon. Thanks for doing all the editorial work <AutomatedTester> orkon: I've updated links etc <orkon> present- <jgraham> RSSAgent make minutes <jgraham> zakim, bye <Zakim> leaving. As of this point the attendees have been AutomatedTester, jimevans, orkon, jgraham, jdescottes, sasha, jugglinmike <jgraham> RRSAgent make minutes <jgraham> RRSAgent: make minutes <RRSAgent> I have made the request to generate https://www.w3.org/2024/07/10-webdriver-minutes.html jgraham <jgraham> RRSAgent: bye <RRSAgent> I see 2 open action items saved in https://www.w3.org/2024/07/10-webdriver-actions.rdf : <RRSAgent> ACTION: David to find out who will be remote for the meetings [1] <RRSAgent> recorded in https://www.w3.org/2024/07/10-webdriver-irc#T16-12-16 <RRSAgent> ACTION: Please read the issue and leave comments (all) [2] <RRSAgent> recorded in https://www.w3.org/2024/07/10-webdriver-irc#T16-45-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really close, just a few small issues that I noticed.
Co-authored-by: jgraham <[email protected]>
Co-authored-by: jgraham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
jgraham marked as non substantive for IPR from ash-nazg. |
Since this is basically a (large) editorial change, and the underlying problem is that rejoining the group is taking some time, I this this should be fine to merge. |
This PR updates the specification to define interactions with browsing contexts in terms of HTML spec's navigables without changing the API (which keeps using "browsingContext" and "context" to refer to navigables).
Closes #91
Preview | Diff