Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch remaining cases of void #171

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Patch remaining cases of void #171

merged 2 commits into from
Apr 14, 2021

Conversation

foolip
Copy link
Member

@foolip foolip commented Apr 14, 2021

All remaining cases have open pull requests or issues.

@foolip
Copy link
Member Author

foolip commented Apr 14, 2021

This will conflict with #168, but resolving the conflicts will be trivial.

From a8fbc3ca92b35de70d2639bc4fbe902b97c30c17 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= <[email protected]>
Date: Wed, 14 Apr 2021 09:11:50 +0200
Subject: [PATCH] Fix void in SVG.idl
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is ed/idlpatches/SVG-void.idl.patch instead of merging with ed/idlpatches/SVG.idl.patch, on the expectation that this patch can soon be dropped while the existing one cannot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm going to fold svg-animations.idl.patch into this, since it's from the same spec PR.

All remaining cases have open pull requests or issues.
@tidoust tidoust merged commit 3a8e56e into master Apr 14, 2021
@foolip foolip deleted the replace-void branch April 14, 2021 09:29
foolip added a commit that referenced this pull request Apr 15, 2021
The new guarantees around validity and consistency warrant a minor
release:
#167
#168
#171
#172
tidoust added a commit that referenced this pull request Apr 15, 2021
All remaining cases have open pull requests or issues.

Co-authored-by: François Daoust <[email protected]>
tidoust pushed a commit that referenced this pull request Apr 15, 2021
The new guarantees around validity and consistency warrant a minor
release:
#167
#168
#171
#172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants