Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nidhijaju committed Mar 6, 2023
1 parent 594d6eb commit 6fd6810
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ To <dfn>pullDatagrams</dfn>, given a {{WebTransport}} object |transport|, run th
1. Set |chunk| to |view|.
1. Otherwise:
1. Set |offset| to 0.
1. Set |maxBytes| to an [=implementation-defined=] size.
1. Set |maxBytes| to the size of |bytes|.
1. Set |buffer| be a [=new=] {{ArrayBuffer}} with |maxBytes| size. If allocating the
{{ArrayBuffer}} fails, return [=a promise rejected with=] a {{RangeError}}.
1. Set |chunk| to a new {{Uint8Array}} object with |buffer| and |offset|.
Expand Down Expand Up @@ -748,6 +748,7 @@ agent MUST run the following steps:
Note: Using 64kB buffers with datagrams is recommended because the effective
maximum WebTransport datagram frame size has an upper bound of the QUIC maximum datagram frame size
which is recommended to be 64kB (See [[!QUIC-DATAGRAM]] [Section 3](https://datatracker.ietf.org/doc/html/rfc9221#section-3)).
This will ensure the stream is not errored due to a datagram being larger than the buffer.

1. [=ReadableStream/Set up with byte reading support=] |incomingDatagrams| with
[=ReadableStream/set up with byte reading support/pullAlgorithm=] set to
Expand Down

0 comments on commit 6fd6810

Please sign in to comment.