Delmonicos Milestone 2 delivery

[lumena-tech]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application PR: w3f/Grants-Program#283

[semuelle]

Hi @lumena-tech, could you review deliverables 0c and 0d? The unit tests don't seem to be mentioned in the docs anywhere, and I don't see 0d in the submission. Thanks!

[adetante]

Hi @semuelle, thanks for your feedback.

I have updated the Testing Guide with the command to run the unit tests, this PR will be updated soon with the fixed link to the Testing Guide.

For deliverable 0d, we plan to do a Medium post on all what we have done in the context of this grant, so preferably in milestone 3. Is it possible to postpone this deliverable 0d in milestone 3?

[semuelle]

Hey Antoine,
thanks for the quick reply. Since you also have Article/Tutorial deliverables in M2 and M3, I'd suggest you create a .md file in your repo that gives less tech-savvy people a rough idea what your code is about, which you can then expand for your Medium article. Feel free to use some of the material from your application.

[adetante]

Thanks @semuelle for your feedback, we will do that: a first version as a .md file in this repository, and later create a dedicated Medium article.

[semuelle]

Can you update this PR with a link to deliverable 0d once it's ready? Thanks.

[lumena-tech]

That's done. The PR has been updated with the link. Regards.

[semuelle]

The link to the membership pallet is not valid, and I can't find the pallet in any of the other branches. Could you fix the link for deliverable 2?
And could you describe what the issue with compiling smart contracts was?

[lumena-tech]

I've updated the PR. Actually we have used the registrar pallet instead of the membership pallet. The note was already mentioning the registrar pallet.

[semuelle]

It seems that the registrar pallet was published under Apache 2 license, which means you should include a copyright notice with the original author. Or was this published elsewhere under a different license?

[lumena-tech]

I presume Dan Forbes is the original author. We took the pallet from : https://github.com/substrate-developer-hub/substrate-enterprise-sample/blob/master/chain/pallets/registrar/.
Where should I add the copyright notice ?

[semuelle]

Where should I add the copyright notice ?

https://infra.apache.org/licensing-howto.html

[lumena-tech]

Hello. That's done. I've added the NOTICE file : https://github.com/Delmonicos/charger-node/blob/main/NOTICE

[semuelle]

Thanks for the update, @lumena-tech. I updated my evaluation notes and your milestone is hereby accepted.

The testing guide was easy to follow, and everything worked out of the box. I found the inline documentation lacking, and some functions aren't covered by unit tests at all. Also, consider using cargo clippy to check your code for possible issues.

Lastly, we preferred if you announced changes in deliverables against the contract beforehand. The changes you made in this milestone are fine, but we had issues with not-as-expected deliverables in the past, so it's safest to amend the contract beforehand.

I will forward your invoice for processing.

[semuelle]

Hi @lumena-tech, your contract specifies a BTC address, and the invoice you submitted only contains a bank account. Could you submit an invoice with your BTC address instead?

[lumena-tech]

Hi. For the first delivery, we had an ETH address with an amount in DAI. If I issue an invoice with a BTC address, in which currency should I specify the amount ?

[Noc2]

@lumena-tech the payment in DAI is also fine. We forgot about the amendment. Could you add the ethereum address of your contract to your invoice? This way we make sure we don’t pay the wrong team or person, since in theory anyone can submit an invoice via the invoice form.

[lumena-tech]

@Noc2 That's done I've submitted a new invoice with the right ethereum address for the payment in DAI.

[Noc2]

Thanks!

[RouvenP]

hi @lumena-tech we transferred the payment for M2 today.