Add optional JSON flag to only show version number for modlist image in install view #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me, but I wouldn't stray too far from the C# coding guidelines that are used elsewhere in the project. Makes it a bit of a mess in the code having snake_case and PascalCase mixed in there combined with { and } being on the same lines as the statement |
erri120
requested changes
Jul 30, 2023
Right you are, sorry, muscle memory kicks in and I forget about c# stuff :D |
…ge in installer view, if the modlist image already contains the title removed debug code change to pascal case and match existing code style update changelog
JanuarySnow
force-pushed
the
crit_obscure_old_request
branch
from
daacd67 to
4d688b7
Compare
erri120
approved these changes
Jul 30, 2023
tr4wzified
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1524
Bit of an obscure one, but it dosnt impact those who dont want it.
Add an optional flag in the modlist metadata json for
DisplayVersionOnlyInInstallerView = trueif this is true, then the version number only is displayed over the modlist image in the installer view, to remain consistent with the same behavior in the gallery tile view ( where there is no overlaid title for images that have title in them )
This new behavior is down to personal preference even more so dosnt follow the same flag, and uses a new one.