Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to plumb plugins up to the CLI flags #11

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

RobbieMcKinstry
Copy link
Contributor

@RobbieMcKinstry RobbieMcKinstry commented Oct 28, 2024

Attempt to plumb plugins up to the CLI flags


Add fmt::Display to ResponseStatusCode.


Dirt simple PR to implement displaying of response codes.


Remove dead contingency table code.

This was dead code because I reimplemented contingency tables
in a better way.


Fix Type Incompatibilities between Actors

I had the type signatures incorrect for the actors. Some took Observation,
other T, and the incompatibility is that an Observation is a Group + T,
so DecisionEngines were actually able to be constructed. This commit
fixes the issue and adds a small smoke test to construct a fake
DecisionEngine as proof.


Implement Chi Square engine and add different types of contingency tables.

Copy link
Contributor Author

RobbieMcKinstry commented Oct 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RobbieMcKinstry and the rest of your teammates on Graphite Graphite

@RobbieMcKinstry RobbieMcKinstry marked this pull request as ready for review October 28, 2024 22:01
Copy link
Contributor Author

RobbieMcKinstry commented Oct 28, 2024

Merge activity

  • Oct 28, 6:03 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 28, 6:06 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 28, 6:07 PM EDT: A user merged this pull request with Graphite.

@RobbieMcKinstry RobbieMcKinstry changed the base branch from robbie/actor-architecture to graphite-base/11 October 28, 2024 22:04
@RobbieMcKinstry RobbieMcKinstry changed the base branch from graphite-base/11 to trunk October 28, 2024 22:04
Dirt simple PR to implement displaying of response codes.
This was dead code because I reimplemented contingency tables
in a better way.
I had the type signatures incorrect for the actors. Some took Observation,
other T, and the incompatibility is that an Observation is a Group + T,
so DecisionEngines were actually able to be constructed. This commit
fixes the issue and adds a small smoke test to construct a fake
DecisionEngine as proof.
@RobbieMcKinstry RobbieMcKinstry merged commit a269065 into trunk Oct 28, 2024
9 checks passed
@RobbieMcKinstry RobbieMcKinstry deleted the robbie/cli-driver branch October 28, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant