Improve Testability of Chi Square #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a Rust toolchain file allows us to ensure our CI tests against stable. This file tells Rustup which toolchain to use, and CI will automatically ensure Rust is running the latest version of stable, since we include `rustup update stable` in our CI script. chore: Add Rust toolchain file so we track stable.
This commit is an iteration on the design of the Chi Square calculator. I realized the calculator should be purely functional so we can write better test cases, instead of collecting observations within the calculator itself. This commit rewrites the calculator to be more testable. test: Refactor Chi Square calculator to improve testability.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @RobbieMcKinstry and the rest of your teammates on |
RobbieMcKinstry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve testability of Chi Square calc engine.
This commit is an iteration on the design of the Chi Square calculator.
I realized the calculator should be purely functional so we can write
better test cases, instead of collecting observations within the
calculator itself. This commit rewrites the calculator to be more
testable.
test: Refactor Chi Square calculator to improve testability.
Add Rust Toolchain File
Adding a Rust toolchain file allows us to ensure our CI tests against
stable. This file tells Rustup which toolchain to use, and CI will
automatically ensure Rust is running the latest version of stable, since
we include
rustup update stablein our CI script.chore: Add Rust toolchain file so we track stable.