Remove pyscaffold #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
===========================================
- Coverage 53.06% 35.81% -17.26%
===========================================
Files 92 86 -6
Lines 18946 19563 +617
Branches 1952 2083 +131
===========================================
- Hits 10054 7006 -3048
- Misses 8362 12162 +3800
+ Partials 530 395 -135
Continue to review full report at Codecov.
|
DeepCode's analysis on #3380eb found:👉 View analysis in DeepCode’s Dashboard |
* Moved files from ./wafo to ./src/wafo in order to insulate the package from the setup.py folder. * Updated setup.cfg and setup.py to support /src layout. * Moved sources from ./src/wafo to ./ and updated setup.py accordingly. * Removed dependence on pyscaffold in setup.py Fixed all tests (except wafo.stats.tests) so they work again: * Replaced "seed = int(floor(random.rand(1) * 1e10))" with "seed = int(floor(random.rand(1) * 2.1e9))" in wafo.gaussian because the maximum long int in c is about 2.1e9 which gives an error if seed is larger than this value. * Replaced "pc = p.clip(min=0, max=1)" with "pc = p.clip(min=_TINY, max=1-_EPS)" in order to avoid division by zero in log(pc) and log1p(-pc) in the _logit function in wafo.kdetools.py * Transposed the result from BKRegression.get_grid method in kdetools.py to avoid shape error when the smoothing parameter hs_e is an array. * Refactored BKRegression._wilson_score so it evaluates the Wilson score interval in a more numerically stable way when n is zero. * Fixed _findrfc3_astm and _findrfc5_astm in numba_misc.py so the test works again. Other changes: * Commented out unused code in _findrfc3_astm and _findrfc5_astm. * Made src/wafo/info.py equal to README.rst * Renamed CHANGES.rst to CHANGELOG.rst * Added build_package.py * Simplified wafo.stats * Removed obsolete private submodules of wafo.stats. * Dropped support for python 2.7 * Removed compatibility code for python 2.7 i.e. "from __future__ ...." statements * Replace "n_bad = np.sum(cond0)" with "n_bad = np.count_nonzero(cond0)" in order to optimize for speed in wafo.stats._distn_infrastructure.py * Made sure that the 3'rd argument (num) to numpy.linspace is an integer because it expects an int and will crash on passing a float in kdetools.py * Had to include static libs in building the fortran extensions on Windows but not for Linux. * Modified AICC calculation in BKRegression. * Add plot of the the AICC score in the check_bkregression function in demo.py * Added test of BKRegression.prb_smoothed * Splitted the test_bk_regression_with_wilson into several smaller tests. * Skipping test_bk_regression_with_wilson because it is an unstable test. * Made test_bk_regression_with_beta less strict.....
pbrod
force-pushed
the
remove_pyscaffold
branch
from
49bdadc to
3380ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing work to remove dependence on pyscaffold as well as simplifying the wafo.stats module.
Needs further testing before merging.