Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #72

Closed
jdbruijn opened this issue Jan 29, 2021 · 1 comment
Closed

Versioning #72

jdbruijn opened this issue Jan 29, 2021 · 1 comment

Comments

@jdbruijn
Copy link
Collaborator

In #71, breaking changes were introduced, namely removing the action outputs. I think you should very careful with this type of change and should be releasing this with Semantic Versioning 2.0.0 what could be implied based on the used version numbering.

The goal of this issue is merely to inform you about this, and hopefully resulting in careful thought in the future. Feel free to close it once you've read it, and perhaps given your view on it.

With that in mind, the v2.1.7 release should have been v3.0.0 instead, properly informing users and dependency management tools to handle it appropriately. With it now being released as v2.1.7, users will face unexpected issues if they're using the action output.

FYI I'd have been happy to review #71, and pointed it out there, if it weren't merged and released right away.

@wagoid
Copy link
Owner

wagoid commented Jan 29, 2021

Hi @jdbruijn, thanks for the heads up! Yes, I follow semver on this action, just forgot about this during this PR. Thanks for prompting to review PRs, will add you to future ones 😉

@wagoid wagoid closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants