fix: remove command executions #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands are disabled, so we should not use `core.setFailed` on errors anymore. Closes #70
After the CVE-2020-15228 vulnerability, we can't issue commands with sensitive data on this action anymore. Due to that, the JSON output that this action generated was removed.
Closed
wagoid
force-pushed
the
fix/remove-outputs-generation
branch
from
5b1b9bb to
b674cd3
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the formatting issues reported on #70, and also removes the output generation that was still making the action susceptible to the CVE-2020-15228 vulnerability.
Once github removes the
add-pathandset-envcommands from runners, we can bring back those 2 features again.