Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support asymmetric algorithms #40

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Support asymmetric algorithms #40

merged 1 commit into from
Sep 4, 2022

Conversation

norydev
Copy link
Contributor

@norydev norydev commented Sep 1, 2022

Description

For asymmetric algorithms, the decoding secret is different than the encoding secret. This change adds support for an optional decoding secret configuration.

@norydev
Support asymmetric algorithms
5454dfc 
For asymetric algorithms, the decoding secret is different than the
encoding secret. This change adds support for an optional decoding
secret configuration.
@norydev
Copy link
Contributor Author

norydev commented Sep 1, 2022

Reason for PR: I would love to be able to use this library with RS256 algorithm, which necessitates this change.

waiting-for-dev
waiting-for-dev approved these changes Sep 4, 2022
View reviewed changes
Copy link
Owner

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for your collaboration. Do you need a new release with this change?

@waiting-for-dev waiting-for-dev merged commit 8a3077b into waiting-for-dev:master Sep 4, 2022
@norydev
Copy link
Contributor Author

norydev commented Sep 6, 2022

Awesome! Thanks for your collaboration

My pleasure 🙂

Do you need a new release with this change?

sure, that would be awesome!

@norydev norydev deleted the support-asymmetric-algorithms branch September 6, 2022 07:40
@waiting-for-dev
Copy link
Owner

Released in v0.7.0! 🚀

@Eric-Guo
Copy link
Contributor

I just upgrade to 0.7.0 today and find it maybe having a break change, I'm not yet check it, but I'm sure in client code side, it must do some configuration.

@waiting-for-dev
Copy link
Owner

Please, report if you find more details. Thanks!

@krnjn
Copy link

krnjn commented Sep 14, 2022

I also encountered a breaking change with this here -- is there some configuration change we need to make in order to be compatible with the change introduced in this PR? Effectively, the JWT strategy no longer works in our case. I can dig in more later, but am happy to introduce an update / config change if there's a suggested one to comply with this new feature.

@waiting-for-dev
Copy link
Owner

Please, see waiting-for-dev/devise-jwt#250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@norydev @waiting-for-dev @Eric-Guo @krnjn