Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react dependencies #78

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Fix react dependencies #78

merged 1 commit into from
Jan 6, 2021

Conversation

danez
Copy link
Contributor

@danez danez commented Apr 23, 2019

This fixes several issues with react:

  • create-react-class is a runtime dependency not a dev dependency
  • react-addons-css-transition-group does not work with the newer versions of react, so it needed to be exchanged with the newer package react-transition-group
  • PropTypes are not part of react anymore and instead are a separate package. But as they are only used in one single component I removed them for now instead of installing another package.

I have a working version locally for chrome of this plugin and this were some problems I had to fix on the way.

@alanhamlett alanhamlett merged commit a183bd3 into wakatime:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants