Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize panic messages #1149

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Standardize panic messages #1149

merged 1 commit into from
Jan 3, 2025

Conversation

gandarez
Copy link
Member

@gandarez gandarez commented Jan 3, 2025

This PR standardizes all panic messages following the format: panicked: %s. Stack: %s to include stack trace.

@gandarez gandarez requested a review from alanhamlett January 3, 2025 10:25
@gandarez gandarez self-assigned this Jan 3, 2025
@gandarez gandarez force-pushed the feature/panic-message branch from 8f3c11f to a0df958 Compare January 3, 2025 10:27
@gandarez gandarez enabled auto-merge January 3, 2025 10:27
@gandarez gandarez merged commit 540a2ab into develop Jan 3, 2025
11 of 12 checks passed
@gandarez gandarez deleted the feature/panic-message branch January 3, 2025 10:30
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.95%. Comparing base (5949ada) to head (a0df958).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
cmd/api/api.go 0.00% 1 Missing and 1 partial ⚠️
cmd/params/params.go 0.00% 1 Missing ⚠️
@@           Coverage Diff            @@
##           develop    #1149   +/-   ##
========================================
  Coverage    62.95%   62.95%           
========================================
  Files          386      386           
  Lines        16902    16902           
========================================
  Hits         10640    10640           
  Misses        5686     5686           
  Partials       576      576           
Flag Coverage Δ
unittests 62.95% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/params/params.go 81.18% <0.00%> (ø)
cmd/api/api.go 46.55% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants