Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added completion to profiles #159

Merged
merged 2 commits into from
Nov 3, 2017
Merged

Added completion to profiles #159

merged 2 commits into from
Nov 3, 2017

Conversation

padilo
Copy link
Contributor

@padilo padilo commented Oct 30, 2017

Adds autocompletion to profiles

@simcap
Copy link
Contributor

simcap commented Oct 30, 2017

Thanks!

For this one @padilo , if a file does not exists (ex: ~/.aws/config .... not everybody has this file present unfortunately) the completion will throw out an error.

Before we merge this one the bash script should handle grep on non existing file (i.e. file exists check beforehand).

Good job! Will be very useful.

@padilo
Copy link
Contributor Author

padilo commented Oct 30, 2017

Cool, I'll improve that ;)

@padilo
Copy link
Contributor Author

padilo commented Nov 3, 2017

@simcap, should be solved now. Also rebased on top of master

@simcap
Copy link
Contributor

simcap commented Nov 3, 2017

Thanks @padilo . Merged.

@simcap simcap merged commit c2ba09d into wallix:master Nov 3, 2017
@padilo padilo deleted the completion-profiles branch November 6, 2017 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants