ASN 856 parser should not throw exception when non-DTM segment found before HL #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSmell
changed the title
CodeSmell
changed the title
CodeSmell
commented
May 4, 2021
| if (DTMDateTimeReference.IDENTIFIER.equals(segmentId)) { | ||
| txSet.addDTMDateTimeReference(DTMDateTimeReferenceParser.parse(currentSegment)); | ||
| } else { | ||
| throw X12ParsingUtil.handleUnexpectedSegment(X12Loop.HIERARCHY_LOOP_ID, segmentId); |
There was a problem hiding this comment.
was debating adding the unexpected segment to a list
List<X12Segment> unexpectedSegmentsBeforeLoop;
this would give the user an opportunity to assess them
There was a problem hiding this comment.
more I thought about it, the more it makes sense to make these segments available... update coming soon
jaympatel
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of changes for #115