This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
View helper fails when run via mutating array #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the conditions that would lead to any side effects? |
|
@eastridge what do you mean? |
|
@kpdecker Was just asking if there was any reason this would cause undesirable behavior that we should test for. If you don't think so is good to merge. |
|
I can't think of any but it's been awhile since I looked at this code. Going to merge as I hope the tests are enough to capture anything. |
kpdecker
added a commit
that referenced
this pull request
Oct 15, 2013
View helper fails when run via mutating array
|
Released in 2.0.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that this is related to the
@indexvalue changing, causing a parameter mismatch incompareHelperOptions.Failing unit tests attached.