This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
Add as a child before calling ensureRender in CollectionView#appendItem #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `this.parent` to be available during `render` of the child item view.
kpdecker
added a commit
that referenced
this pull request
Apr 12, 2014
Add as a child before calling ensureRender in CollectionView#appendItem
jasonwebster
pushed a commit
to metalabdesign/exo
that referenced
this pull request
Apr 14, 2014
jasonwebster
pushed a commit
to metalabdesign/exo
that referenced
this pull request
Apr 15, 2014
carpeliam
added a commit
to pophealth/popHealth
that referenced
this pull request
Apr 16, 2014
…r. Previously, a query was a direct child of a measure. If additional filters are ever used, we'll probably want to make this more universal. When we can upgrade to Thorax 3, we'll want to use `getQueryForProvider` in the `DashboardSubmeasureView` view as well. Currently, it's too difficult to supply the view with a provider_id, but it'll be easier once walmartlabs/thorax#358 is pulled in
|
Released in 3.0.0-alpha.5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
this.parentto be available duringrenderof the child item view.This solves an issue for me where I need to access properties on the parent view in
renderedcallbacks in the item view.