Support rectangular boards #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SGF format is clearly documented to allow for any rectangular non-square board sizes:
https://www.red-bean.com/sgf/properties.html#SZ
However, wgo.js did not appear to support them. This pull request adds support for them, by splitting internally
sizeintosizexandsizey, adjusting the computation of the defaulttx,ty,bx,byso that by default everything is drawn squarely unless the user changes it withsection, and exposing the rectangular option in the API by allowingsizeto be an array of length 2, indicating the sizex and the sizey.