Skip to content

Commit

Permalink
fix: Upgrade bufstream to 0.3.5
Browse files Browse the repository at this point in the history
  • Loading branch information
danielpanzella committed Jan 13, 2025
1 parent d2403fb commit 8402217
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 9 deletions.
2 changes: 1 addition & 1 deletion charts/operator-wandb/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ dependencies:
repository: oci://registry-1.docker.io/bitnamicharts
condition: bufstream.install
- name: bufstream
version: "0.3.1"
version: "0.3.5"
repository: file://charts/bufstream
condition: global.beta.bufstream.enabled
- name: otel
Expand Down
2 changes: 1 addition & 1 deletion charts/operator-wandb/charts/bufstream/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
apiVersion: v2
name: bufstream
version: 0.3.1
version: 0.3.5
10 changes: 6 additions & 4 deletions charts/operator-wandb/charts/bufstream/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
| bufstream.deployment.tolerations | list | `[]` | Bufstream Deployment Tolerations. |
| bufstream.image.pullPolicy | string | `"IfNotPresent"` | Bufstream Deployment container image pull policy. |
| bufstream.image.repository | string | `"us-docker.pkg.dev/buf-images-1/bufstream-public/images/bufstream"` | Bufstream Deployment container image repository. |
| bufstream.image.tag | string | `"0.3.1"` | Overrides the image tag whose default is the chart version. |
| bufstream.image.tag | string | `"0.3.5"` | Overrides the image tag whose default is the chart version. |
| bufstream.podDisruptionBudget.enabled | bool | `false` | Whether to enable pod disruption budget. |
| bufstream.podDisruptionBudget.maxUnavailable | string | `""` | Number of pods that are unavailable after eviction as number or percentage (eg.: 50%). Has higher precedence over `minAvailable` |
| bufstream.podDisruptionBudget.minAvailable | string | `""` (defaults to 0 if not specified) | Number of pods that are available after eviction as number or percentage (eg.: 50%). |
Expand Down Expand Up @@ -76,7 +76,7 @@
| kafka.requestBufferSize | int | `5` | The number of kafka request to unmarshal and buffer before processing. |
| kafka.tlsCertificateSecrets | list | `[]` | Kubernetes secrets containing a `tls.crt` and `tls.key` (as the secret keys, see https://kubernetes.io/docs/concepts/configuration/secret/#tls-secrets) to present to the client. The first certificate compatible with the client's requirements is selected automatically. |
| kafka.tlsClientAuth | string | `"NO_CERT"` | Declare the policy the server will follow for mutual TLS (mTLS). Supported values are [NO_CERT, REQUEST_CERT, REQUIRE_CERT, VERIFY_CERT_IF_GIVEN, REQUIRE_AND_VERIFY_CERT]. Only supported when using tlsCertificateSecret. |
| kafka.tlsClientCasSecret | string | `""` | Kubernetes seccret containing a `tls.crt` (as the secret key) PEM-encoded certificate authorities used by the server to validate the client certificates. This field cannot be empty if tlsClientAuth is set for client performing verification. Only supported when using tlsCertificateSecret. |
| kafka.tlsClientCasSecret | string | `""` | Kubernetes secret containing a `tls.crt` (as the secret key) PEM-encoded certificate authorities used by the server to validate the client certificates. This field cannot be empty if tlsClientAuth is set for client performing verification. Only supported when using tlsCertificateSecret. |
| kafka.zoneBalanceStrategy | string | `"BALANCE_STRATEGY_PARTITION"` | How to balance clients across zones, when client does not specify a zone. One of: ["BALANCE_STRATEGY_UNSPECIFIED", "BALANCE_STRATEGY_PARTITION", "BALANCE_STRATEGY_HOST", "BALANCE_STRATEGY_CLIENT_ID"] |
| metadata.etcd.addresses | list | `[]` | Etcd addresses to connect to. |
| metadata.etcd.tls | object | `{}` | TLS client configuration for bufstream to connect to etcd. |
Expand All @@ -88,14 +88,16 @@
| observability.exporter.insecure | bool | `false` | Whether to disable TLS for the exporter's HTTP connection. This can be overriden by metrics.insecure or tracing.insecure. |
| observability.logLevel | string | `"INFO"` | Log level to use. |
| observability.metrics.address | string | `""` | The endpoint the exporter connects to. The value has a host and an optional port. It should not include the URL path, such as "/v1/metrics" or the scheme. Specify path and insecure instead. |
| observability.metrics.aggregation.consumerGroups | bool | `false` | |
| observability.metrics.aggregation.partitions | bool | `false` | |
| observability.metrics.aggregation.topics | bool | `false` | |
| observability.metrics.exporter | string | `""` | Open Telemetry exporter. Supports [NONE, STDOUT, HTTP, HTTPS, PROMETHEUS]. Deprecated: use exporterType instead. |
| observability.metrics.exporterType | string | `"NONE"` | Open Telemetry exporter. Supports [NONE, STDOUT, OTLP_GRPC, OTLP_HTTP, PROMETHEUS] |
| observability.metrics.insecure | bool | `false` | Whether to disable TLS. This can only be specified for OTLP_HTTP exporter type. |
| observability.metrics.omitPartitionAttribute | bool | `false` | |
| observability.metrics.otlpTemporalityPreference | string | `""` | |
| observability.metrics.path | string | `""` | |
| observability.otlpEndpoint | string | `""` | Open Telemetry base endpoint to push metrics and traces to. Deprecated: use exporter.address and exporter.insecure instead. |
| observability.sensitiveInformationRedaction | string | `"NONE"` | Redact sensitive information such as topic names, before adding to to metrics, traces and logs. Supports [NONE, OPAQUE, OMITTED] |
| observability.sensitiveInformationRedaction | string | `"NONE"` | Redact sensitive information such as topic names, before adding to to metrics, traces and logs. Supports [NONE, OPAQUE] |
| observability.tracing.address | string | `""` | The endpoint the exporter connects to. The value has a host and an optional port. It should not include the URL path, such as "/v1/traces" or the scheme. Specify path and insecure instead. |
| observability.tracing.exporter | string | `""` | Open Telemetry exporter. Supports [NONE, STDOUT, HTTP, HTTPS]. Deprecated: use exporterType instead. |
| observability.tracing.exporterType | string | `"NONE"` | Open Telemetry exporter. Supports [NONE, STDOUT, OTLP_GRPC, OTLP_HTTP] |
Expand Down
6 changes: 6 additions & 0 deletions charts/operator-wandb/charts/bufstream/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@ observability:
{{- if .Values.observability.metrics.enableInternalMetrics }}
enable_internal_metrics: {{ .Values.observability.metrics.enableInternalMetrics }}
{{- end }}
{{- if or .Values.observability.metrics.aggregation.topics .Values.observability.metrics.aggregation.partitions .Values.observability.metrics.aggregation.consumerGroups }}
aggregation:
topics: {{ .Values.observability.metrics.aggregation.topics }}
partitions: {{ .Values.observability.metrics.aggregation.partitions }}
consumer_groups: {{ .Values.observability.metrics.aggregation.consumerGroups }}
{{- end }}
{{- end }}
debug_address:
host: 0.0.0.0
Expand Down
22 changes: 19 additions & 3 deletions charts/operator-wandb/charts/bufstream/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ kafka:
# -- Declare the policy the server will follow for mutual TLS (mTLS). Supported values are [NO_CERT, REQUEST_CERT, REQUIRE_CERT, VERIFY_CERT_IF_GIVEN, REQUIRE_AND_VERIFY_CERT]. Only supported when using tlsCertificateSecret.
# @default -- `"NO_CERT"`
tlsClientAuth: ""
# -- Kubernetes seccret containing a `tls.crt` (as the secret key) PEM-encoded certificate authorities used by the server to validate the client certificates. This field cannot be empty if tlsClientAuth is set for client performing verification. Only supported when using tlsCertificateSecret.
# -- Kubernetes secret containing a `tls.crt` (as the secret key) PEM-encoded certificate authorities used by the server to validate the client certificates. This field cannot be empty if tlsClientAuth is set for client performing verification. Only supported when using tlsCertificateSecret.
tlsClientCasSecret: ""
# -- If a fetch should return as soon as any records are available.
fetchEager: true
Expand Down Expand Up @@ -156,6 +156,8 @@ observability:
# depending on the configuration. One example is kafka.topic.partition.offset.high_water_mark.
# This omits only the attribute for metrics that have this attribute without depending on it.
# One example is kafka.produce.record.size.
# Deprecated: set aggregation.partitions to true instead.
# @ignored
omitPartitionAttribute: false
# Whether to emit bufstream.internal.* metrics.
# @ignored
Expand All @@ -164,6 +166,20 @@ observability:
# This is recommended to be set to "delta" for reporting to Datadog agents.
# See https://docs.datadoghq.com/opentelemetry/guide/otlp_delta_temporality/ for more details.
otlpTemporalityPreference: ""
# This option, typically set to reduce cardinality, aggregates some metrics over certain attributes, such as kafka.topic.name.
aggregation:
# Aggregate metrics across all topics to avoid cardinality issues with clusters with a large number of topics.
# Metrics that support this aggregation will report the 'kafka.topic.name' attribute as '_all_topics_'.
# NOTE: This implies partitions aggregation, which omits metrics like 'bufstream.kafka.topic.partition.offset.high_water_mark'.
topics: false
# Aggregate metrics across all parttions to avoid cardinality issues with clusters with a large number of partitions.
# Metrics that support aggregation will report the 'kafka.partition.id' attribute as -1, while some metrics, such as
# 'bufstream.kafka.topic.partition.offset.high_water_mark' will be omitted if partition level aggregation is enabled.
partitions: false
# Aggregate metrics across all consumer groups to avoid cardinality issues with clusters with a large number of groups.
# Metrics that support aggregation will report the 'kafka.consumer.group.id' as '_all_groups_', while some metrics
# such as 'bufstream.kafka.consumer.group.generation' will be omitted if consumer group level aggregation is enabled.
consumerGroups: false
tracing:
# -- Open Telemetry exporter. Supports [NONE, STDOUT, HTTP, HTTPS].
# Deprecated: use exporterType instead.
Expand All @@ -183,7 +199,7 @@ observability:
# -- Trace sample ratio.
traceRatio: 0.1
# -- Redact sensitive information such as topic names, before adding to to metrics, traces and logs.
# Supports [NONE, OPAQUE, OMITTED]
# Supports [NONE, OPAQUE]
sensitiveInformationRedaction: "NONE"
bufstream:
service:
Expand Down Expand Up @@ -295,7 +311,7 @@ bufstream:
# -- Bufstream Deployment container image repository.
repository: us-docker.pkg.dev/buf-images-1/bufstream-public/images/bufstream
# -- Overrides the image tag whose default is the chart version.
tag: "0.3.1"
tag: "0.3.5"
# -- Bufstream Deployment container image pull policy.
pullPolicy: IfNotPresent
# -- Extra Kubernetes objects to install as part of this chart.
Expand Down

0 comments on commit 8402217

Please sign in to comment.