Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Init Settings Migration Job #298

Merged
merged 49 commits into from
Jan 14, 2025
Merged

feat: Init Settings Migration Job #298

merged 49 commits into from
Jan 14, 2025

Conversation

zacharyblasczyk
Copy link
Contributor

No description provided.

@zacharyblasczyk zacharyblasczyk marked this pull request as ready for review January 6, 2025 17:47
@zacharyblasczyk zacharyblasczyk changed the base branch from danielpanzella/add-jobs to main January 6, 2025 22:16
@zacharyblasczyk zacharyblasczyk changed the title feat: Init gorilla feat: Init Settings migration hook Jan 13, 2025
@zacharyblasczyk zacharyblasczyk changed the title feat: Init Settings migration hook feat: Init Settings migration Job Jan 14, 2025
@zacharyblasczyk zacharyblasczyk changed the title feat: Init Settings migration Job feat: Init Settings Migration Job Jan 14, 2025
Comment on lines +15 to +16
LICENSE: {{ .Values.global.license }}
GORILLA_LICENSE: {{ .Values.global.license }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we went to test this, it was base64 encoding the base64 encoded secret.

So removing ensured gorilla worked.

When we initially tested with glue, it doesn't check the license.

charts/wandb-base/templates/cronjob Outdated Show resolved Hide resolved
@zacharyblasczyk zacharyblasczyk merged commit 8ab255e into main Jan 14, 2025
1 of 2 checks passed
@zacharyblasczyk zacharyblasczyk deleted the zacharyb/gorilla branch January 14, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants