fix: Bucket postfix trailing slash #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
dacbd
approved these changes
Jan 16, 2025
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
changed the title
vanpelt
reviewed
Jan 17, 2025
|
|
||
| {{- if eq $provider "s3" -}} | ||
| {{- if or (and $accessKey $secretKey) .Values.global.bucket.secret.secretName -}} | ||
| {{- $url = "s3://$(BUCKET_ACCESS_KEY):$(BUCKET_SECRET_KEY)@$(BUCKET_NAME)" -}} |
There was a problem hiding this comment.
Won't this be a problem in the self-hosted s3 case where I believe we end up setting BUCKET_NAME to the url of the s3 server?
There was a problem hiding this comment.
I guess this is ok as path wouldn't be none in that case...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue where there is a trailing
/in the bucket if path is not set.Before:
After
The problem is that then the bucket will be
Before
After
Which can lead to issues with the application.