feat: This branch has a working operator Proof of Concept using minio #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyblasczyk
requested review from
gls4,
jsbroks,
nfoucha and
vanpelt
as code owners
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
jsbroks
reviewed
Oct 17, 2023
| minio-data | ||
| license.txt | ||
| .ds_store | ||
| ``` |
There was a problem hiding this comment.
I assume it is the ``` this is so annoying that my autocomplete adds this. I will clean up.
jsbroks
reviewed
Oct 17, 2023
Comment on lines
+29
to
+40
| is_minio_running() { | ||
| if [ -f "$MINIO_PID_FILE" ]; then | ||
| if ps -p $(cat "$MINIO_PID_FILE") >/dev/null 2>&1; then | ||
| return 0 | ||
| else | ||
| rm "$MINIO_PID_FILE" | ||
| return 1 | ||
| fi | ||
| else | ||
| return 1 | ||
| fi | ||
| } |
There was a problem hiding this comment.
is_minio_running() {
[ -f "$MINIO_PID_FILE" ] && ps -p $(cat "$MINIO_PID_FILE") >/dev/null 2>&1
}
we shouldn't be doing operators in a function that is checking
There was a problem hiding this comment.
Yah, this can be greatly improved, I was just concerned about another instances of minio potentially running on someones machine and was over engineering this. 😅
jsbroks
reviewed
Oct 17, 2023
Comment on lines
+114
to
+116
| bucket: | ||
| name: "$MINIO_ROOT_USER:[email protected]:9000/$MINIO_WANDB_BUCKET" | ||
| region: "us-east-2" |
There was a problem hiding this comment.
Suggested change
| bucket: | |
| name: "$MINIO_ROOT_USER:$MINIO_ROOT_PASSWORD@host.docker.internal:9000/$MINIO_WANDB_BUCKET" | |
| region: "us-east-2" | |
| bucket: | |
| accessKey: MINIO_ROOT_USER | |
| secretKey: MINIO_ROOT_PASSWORD | |
| name: host.docker.internal:9000" | |
| region: "us-east-2" | |
| path: MINIO_WANDB_BUCKET # this part doesn't work we need to fix this |
There was a problem hiding this comment.
Yah, this needs fixing. Just hacked for now.
jsbroks
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply set your kubernetes context to your local docker desktop environment, set a
license.txtin the root of this repo,and
./run-operator.shto get a fully working operator up and running locally.(Tested on an M1/M2 mac)
This should allow for anyone at W&B to test the operator locally with ease and add features that don't require direct interactions with cloud native resources.
This script will spin up a local version of minio which is a good test for how onprem customers will run our software.
Lastly, run
to access the wandb app at http://localhost:8080 and the console at http://localhost:8081.