Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): add agent.startTimeout value for WANDB_LAUNCH_START_TIMEOUT #38

Merged
merged 4 commits into from
Nov 1, 2023
Merged

feat(launch): add agent.startTimeout value for WANDB_LAUNCH_START_TIMEOUT #38

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94b53ab
add variable for WANDB_LAUNCH_START_TIMEOUT
bcsherma Oct 31, 2023
d1cfebc
wrap number in quotes
bcsherma Oct 31, 2023
dc8f45f
Merge branch 'main' into launch/start_timeout
bcsherma Nov 1, 2023
25b0a6e
Merge branch 'main' into launch/start_timeout
bcsherma Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/launch-agent/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: launch-agent
icon: https://em-content.zobj.net/thumbs/240/apple/354/rocket_1f680.png
description: A Helm chart for running the W&B Launch Agent in Kubernetes
type: application
version: 0.11.0
version: 0.12.0
maintainers:
- name: wandb
email: [email protected]
Expand Down
3 changes: 2 additions & 1 deletion charts/launch-agent/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ The table below describes all the available variables in the chart:
| `agent.useExternalWandbSecret` | bool | **false** | "" | Used to indicate you want to provide the api key secret external to this chart. |
| `agent.image` | string | No | `wandb/launch-agent-dev:latest` | Container image for the agent. |
| `agent.imagePullPolicy` | string | No | `Always` | Pull policy for the agent container image. |
| `agent.resources` | object | No | Limit to 1 CPU, 1Gi RAM | Pod spec resources block for the agent. |
| `agent.resources` | object | No | Limit to 1 CPU, 1Gi RAM | Pod spec resources block for the agent. true |
| `agent.startTimeout` | int | No | `1800` | Timeout in seconds that the agent will wait for a job to start before timing out. |
| `namespace` | string | No | `wandb` | The namespace to deploy the agent into. |
| `additionalTargetNamespaces` | list(string) | No | [`wandb`,`default`] | A list of namespaces the agent can run jobs in. |
| `baseUrl` | string | No | `https://api.wandb.ai` | URL of your W&B server api. |
Expand Down
2 changes: 2 additions & 0 deletions charts/launch-agent/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ spec:
key: wandb-base-url
- name: CM_CHECKSUM
value: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
- name: WANDB_LAUNCH_START_TIMEOUT
value: "{{ .Values.agent.startTimeout }}"
volumeMounts:
- name: wandb-launch-config
mountPath: /home/launch_agent/.config/wandb
Expand Down
2 changes: 2 additions & 0 deletions charts/launch-agent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ agent:
limits:
cpu: 1000m
memory: 1Gi
# Job start timeout (seconds)
startTimeout: 1800

# Namespace to deploy launch agent into
namespace: wandb
Expand Down