Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: DNM Weave plumbing stuff #126

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions examples/public-dns-external/main.tf
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# this assumes your shell is authenticated with gcloud and using playground-111:
# gcloud config set project playground-111
# gcloud auth application-default login
terraform {
backend "gcs" {
bucket = "install.wandb.ai"
prefix = "cvp.wandb.ml"
}
}

provider "aws" {
region = "us-west-2"

Expand Down Expand Up @@ -26,11 +36,12 @@ module "wandb_infra" {
database_sort_buffer_size = var.database_sort_buffer_size

allowed_inbound_cidr = var.allowed_inbound_cidr
allowed_inbound_ipv6_cidr = ["::/0"]
allowed_inbound_ipv6_cidr = var.allowed_inbound_ipv6_cidr

eks_cluster_version = "1.25"
kubernetes_public_access = true
kubernetes_public_access_cidrs = ["0.0.0.0/0"]
kubernetes_instance_types = ["m6a.2xlarge"] # 8 vCPU, 32 GiB RAM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we should prefer m6a.2xlarge over m5.2xlarge allowed in deployer?


domain_name = var.domain_name
zone_id = var.zone_id
Expand All @@ -56,10 +67,27 @@ provider "kubernetes" {
}

module "wandb_app" {
source = "github.com/wandb/terraform-kubernetes-wandb"
# source = "github.com/wandb/terraform-kubernetes-wandb"
source = "../../../terraform-kubernetes-wandb"

license = var.wandb_license

oidc_client_id = var.oidc_client_id
oidc_issuer = var.oidc_issuer

other_wandb_secrets = var.other_wandb_secrets
other_wandb_env = var.other_wandb_env

dd_env = var.datadog_env
weave_enabled = true
weave_enable_datadog = true
weave_dd_profiling_enabled = true
weave_storage_class = "ebs-sc"
weave_storage_provisioner = "ebs.csi.aws.com"
weave_storage_type = "gp3"
weave_storage_size = "250Gi"
parquet_enabled = true

host = module.wandb_infra.url
bucket = "s3://${module.wandb_infra.bucket_name}"
bucket_aws_region = module.wandb_infra.bucket_region
Expand Down
30 changes: 29 additions & 1 deletion examples/public-dns-external/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,42 @@ variable "bucket_kms_key_arn" {
default = ""
}

variable "oidc_issuer" {
type = string
description = "The OIDC issuer URL"
default = ""
}

variable "oidc_client_id" {
type = string
description = "The OIDC client ID"
default = ""
}

variable "other_wandb_secrets" {
type = map(string)
description = "Other secrets env vars to pass to wandb"
default = {}
}

variable "other_wandb_env" {
type = map(string)
description = "Other env vars to pass to wandb"
default = {}
}

variable "datadog_env" {
type = string
description = "The Datadog environment to use"
default = ""
}

variable "allowed_inbound_cidr" {
default = ["0.0.0.0/0"]
nullable = false
type = list(string)
}


variable "allowed_inbound_ipv6_cidr" {
default = ["::/0"]
nullable = false
Expand Down