fix: select columns for child call table preview #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=d8277099dac72d03cd08efd20af4246939ffedac |
tssweeney
reviewed
Oct 2, 2024
| @@ -140,6 +140,9 @@ export const CallsTable: FC<{ | |||
|
|
|||
| paginationModel?: GridPaginationModel; | |||
| setPaginationModel?: (newModel: GridPaginationModel) => void; | |||
|
|
|||
| // Can include glob for prefix match, e.g. "inputs.*" | |||
| shownCols?: string[]; | |||
There was a problem hiding this comment.
Nit: I think this is operating more like a filter - if a column does not match this filter, is it not even selectable in the column picker. I might call this: allowedColumnPatterns or something a bit more specific.
tssweeney
approved these changes
Oct 2, 2024
jamie-rasmussen
force-pushed
the
jamie/child-call-preview-cols
branch
from
f677cf1 to
bcf95d7
Compare
jamie-rasmussen
force-pushed
the
jamie/child-call-preview-cols
branch
from
bcf95d7 to
6c0dcf5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://wandb.atlassian.net/browse/WB-21218
Also sorts attributes after inputs and output in the column management modal.
Before:
After:
Testing
How was this PR tested?