perf: split metadata/val in objects query #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=0feedb6674a3e2e0cb1531730b534f50f94be4c4 |
gtarpenning
changed the title
tssweeney
reviewed
Sep 27, 2024
tssweeney
reviewed
Sep 27, 2024
tssweeney
reviewed
Sep 27, 2024
gtarpenning
commented
Sep 27, 2024
gtarpenning
commented
Oct 1, 2024
| @@ -1578,7 +1600,7 @@ def _query_stream( | |||
| query: str, | |||
| parameters: Dict[str, Any], | |||
| column_formats: Optional[Dict[str, Any]] = None, | |||
| ) -> Iterator[QueryResult]: | |||
| ) -> Iterator[tuple]: | |||
There was a problem hiding this comment.
This does not return a QueryResult! its a tuple...
tssweeney
reviewed
Oct 1, 2024
| ], | ||
| row, | ||
| list(row) + ["{}"], |
There was a problem hiding this comment.
nit: might be nice to comment what this +['{}'] does
gtarpenning
force-pushed
the
griffin/object-query-two-parts-general
branch
from
adfdb67 to
5661b89
Compare
tssweeney
approved these changes
Oct 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2496 but better
Description
This pr:
val_dumpread from the initial select objects queryThis should improve performance on objects with many versions (or lots of data)
version_count(unused afaict),version_indexwhich must see all objects.Performance:
Existing queries that crash due to massive memory requirements (
50GB+) now can be resolved in around 1 second, with a memory requirement less than100MBtotal.Testing