chore(weave): Add conditional ci #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=cc03741fb25eb7c183929c4eb7ea89ed47adb9df |
andrewtruong
commented
Oct 1, 2024
| WEAVE_QUERY_PATHS: 'weave_query/' | ||
| WEAVE_JS_PATHS: 'weave-js/' | ||
| CORE_INTEGRATION_PATHS: 'weave-js/ weave_query/' | ||
| # Everything else is implicitly trace server |
There was a problem hiding this comment.
do we need 1 more for trace server?
There was a problem hiding this comment.
Once we fully isolate trace sdk and trace server, we could further split this
davidwallacejackson
approved these changes
Oct 1, 2024
tssweeney
reviewed
Oct 1, 2024
tssweeney
reviewed
Oct 1, 2024
tssweeney
reviewed
Oct 1, 2024
|
|
||
| jobs: | ||
| check: | ||
| runs-on: ubuntu-latest |
tssweeney
approved these changes
Oct 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cannot be fully tested e2e until both sides are merged into master because
repository_dispatchonly applies on the master branch (of core), but I have tested the individual pieces and it seems to workCompanion to: https://github.com/wandb/core/pull/24362