chore(weave): Move old build files #2551
Conversation
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=924fc8f715859744f5109dde3366375ae056aae3 |
| @@ -1,15 +0,0 @@ | |||
| include requirements.* | |||
There was a problem hiding this comment.
Are you sure we are good to delete this now? won't this result in build usues?
There was a problem hiding this comment.
nah you don't need it, we use pyproject.toml now
There was a problem hiding this comment.
maybe removing the custom builder solves for this?
There was a problem hiding this comment.
Yeah you don't need it.
Try uv build at the repo root
| @@ -0,0 +1,6 @@ | |||
| include requirements.* | |||
There was a problem hiding this comment.
Why are we putting this here? weave_query is not a python package that gets built, right?
There was a problem hiding this comment.
We could if you are confident we will never build this pkg again. You can always go into git history to find this file later if you need it.
Then instead of move, these will be deletes
There was a problem hiding this comment.
i see, probably safe to keep
This just moves the old build files to
weave_queryCompanion:
https://github.com/wandb/core/pull/24371