Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): Project sidebar takes in models access param #2565

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

ethanho154
Copy link
Contributor

@ethanho154 ethanho154 commented Oct 2, 2024

Description

Block Models tabs for weave only user.

Testing

How was this PR tested?

@ethanho154 ethanho154 requested review from a team as code owners October 2, 2024 01:09
Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ethanho154
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 2, 2024
@@ -35,7 +44,7 @@ export const useProjectSidebar = (
type: 'button' as const,
name: 'Overview',
slug: 'overview',
isShown: !isWeaveOnly,
isShown: true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@circle-job-mirror
Copy link

circle-job-mirror bot commented Oct 2, 2024

Copy link
Collaborator

@jamie-rasmussen jamie-rasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanho154 we should discuss this with design team, I think we don't want this tab appearing in Weave.

@ethanho154 ethanho154 changed the title chore(weave): Project sidebar takes in models access param and always shows Overview tab chore(weave): Project sidebar takes in models access param Oct 2, 2024
@ethanho154 ethanho154 merged commit c25223e into master Oct 2, 2024
79 checks passed
@ethanho154 ethanho154 deleted the ethan/weave-only-sidebar branch October 2, 2024 21:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants