Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: eval selection bar UI tweaks #2592

Merged
merged 4 commits into from
Oct 10, 2024
Merged

chore: eval selection bar UI tweaks #2592

merged 4 commits into from
Oct 10, 2024

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Oct 2, 2024 •
edited
Loading

Description

Update the eval bar to new ui:

  • remove swap button
  • remove model name from eval header
  • remove evals from the bar
  • add evals from selector of all evals in the project

Current state:
eval-state-add-2

TODO:

  • include added evaluations in URL state
Screenshot 2024-10-02 at 4 14 36 PM

Testing

How was this PR tested?

@circle-job-mirror
Copy link

circle-job-mirror bot commented Oct 2, 2024 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=e45e7a61b441e74e33fd2d6e2347eb23b5e35fef

@gtarpenning gtarpenning mentioned this pull request Oct 8, 2024
Merged
@gtarpenning gtarpenning changed the title chore: eval selection bar chore: eval selection bar UI tweaks Oct 9, 2024
@gtarpenning gtarpenning marked this pull request as ready for review October 9, 2024 00:07
@gtarpenning gtarpenning requested review from a team as code owners October 9, 2024 00:07
@gtarpenning gtarpenning mentioned this pull request Oct 10, 2024
Merged
@gtarpenning gtarpenning merged commit 8d5d38b into master Oct 10, 2024
85 checks passed
@gtarpenning gtarpenning deleted the griffin/eval-no-model-name branch October 10, 2024 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tssweeney tssweeney tssweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtarpenning @tssweeney