Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add back image tests to test suite #2616

Merged
merged 2 commits into from
Oct 8, 2024
Merged

chore: Add back image tests to test suite #2616

merged 2 commits into from
Oct 8, 2024

Conversation

tssweeney
Copy link
Collaborator

No description provided.

@circle-job-mirror
Copy link

circle-job-mirror bot commented Oct 7, 2024 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=9bd3448b12cae10bf81c965041c3da4ab48d8315

@tssweeney tssweeney marked this pull request as ready for review October 7, 2024 23:37
@tssweeney tssweeney requested a review from a team as a code owner October 7, 2024 23:37
andrewtruong
andrewtruong approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@andrewtruong andrewtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these weren't being run before?

@tssweeney
Copy link
Collaborator Author

these weren't being run before?

Correct:

    default_test_dirs = [f"integrations/{shard}/"]
    test_dirs_dict = {
        "trace": ["trace/"],
        "trace_server": ["trace_server/"],
        "mistral0": ["integrations/mistral/v0/"],
        "mistral1": ["integrations/mistral/v1/"],
    }

@tssweeney tssweeney merged commit 403ede5 into master Oct 8, 2024
79 checks passed
@tssweeney tssweeney deleted the tim/image_tests branch October 8, 2024 00:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewtruong andrewtruong andrewtruong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tssweeney @andrewtruong