Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): fix sentry dedupe of useNodevalue error #2645

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

bcsherma
Copy link
Contributor

@bcsherma bcsherma commented Oct 9, 2024

Description

Dedupes the recording of the useNodeValue error in sentry. Uses a helper to throw the error with a suffix attached that causes the sentry capture at the error boundary to be ignored since we have already captured the error.

Copy link
Contributor Author

bcsherma commented Oct 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bcsherma and the rest of your teammates on Graphite Graphite

@circle-job-mirror
Copy link

circle-job-mirror bot commented Oct 9, 2024

@bcsherma bcsherma marked this pull request as ready for review October 9, 2024 18:51
@bcsherma bcsherma requested a review from a team as a code owner October 9, 2024 18:51
@bcsherma bcsherma force-pushed the use-node-val branch 4 times, most recently from 2a8fe1f to 692d9e2 Compare October 10, 2024 16:11
@bcsherma bcsherma enabled auto-merge (squash) October 10, 2024 20:18
@bcsherma bcsherma merged commit e2f5eea into master Oct 10, 2024
99 checks passed
@bcsherma bcsherma deleted the use-node-val branch October 10, 2024 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants