fix(weave): Use sdk-local deserializer instead of saved deserializer for known types like Images #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=f611342a50326fd6684a9d1096dea46d2cc58dd2 |
andrewtruong
changed the title
andrewtruong
changed the title
andrewtruong
changed the title
tssweeney
reviewed
Nov 6, 2024
weave/trace/custom_objs.py
Outdated
| load_instance_op = None | ||
| if load_instance_op_uri is not None: | ||
| if weave_type["type"] in KNOWN_TYPES: | ||
| serializer = get_serializer_by_id(weave_type["type"]) |
There was a problem hiding this comment.
what happens if the serialization changes? It seems like we should first "try" the local version, then fallback to the remote version, then error
There was a problem hiding this comment.
ok yeah that's safer
andrewtruong
force-pushed
the
andrew/known-serde
branch
from
49fe855 to
5bfa718
Compare
tssweeney
reviewed
Nov 7, 2024
| found_serializer = False | ||
|
|
||
| # First, try to load the object using a known serializer | ||
| if _type in KNOWN_TYPES: |
There was a problem hiding this comment.
this is still not quite right - we need to try with the local one first, else fallback to the the remote one
tssweeney
reviewed
Nov 7, 2024
tssweeney
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://wandb.atlassian.net/browse/WB-21517
Testing
Unit tests and manual testing